Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo deletion #3140

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix repo deletion #3140

merged 1 commit into from
Apr 19, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Apr 19, 2024

Summary

We passed the wrong ID.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

minder repo delete

this was caught by smoke tests, so we'll have test coverage once this is merged

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We passed the wrong ID.
@jhrozek jhrozek requested a review from a team as a code owner April 19, 2024 17:55
@coveralls
Copy link

Coverage Status

coverage: 47.883% (+0.006%) from 47.877%
when pulling 0eeed85 on jhrozek:fix_repo_delete
into 5ed6788 on stacklok:main.

@jhrozek jhrozek merged commit 0085d91 into mindersec:main Apr 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants