Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to go-viper blessed fork of mapstructure #3149

Conversation

evankanderson
Copy link
Member

Summary

See: https://github.com/go-viper/mapstructure/releases/tag/v1.6.0

There will be a v2 version, but it's currently in alpha.

Fixes #3148

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Unit tests

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner April 23, 2024 17:59
@evankanderson evankanderson linked an issue Apr 23, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Apr 23, 2024

Coverage Status

coverage: 50.314% (-0.005%) from 50.319%
when pulling 34fdb44 on evankanderson:3148-migrate-from-mitchellhmapstructure-to-go-vipermapstructure
into 6c47102 on stacklok:main.

puerco
puerco previously approved these changes Apr 24, 2024
go.mod Outdated Show resolved Hide resolved
dmjb
dmjb previously approved these changes Apr 24, 2024
@evankanderson
Copy link
Member Author

…itchellhmapstructure-to-go-vipermapstructure
@evankanderson evankanderson dismissed stale reviews from dmjb and puerco via 6e03ff2 May 8, 2024 04:35
@evankanderson evankanderson force-pushed the 3148-migrate-from-mitchellhmapstructure-to-go-vipermapstructure branch from f709597 to 6e03ff2 Compare May 8, 2024 04:35
@evankanderson evankanderson force-pushed the 3148-migrate-from-mitchellhmapstructure-to-go-vipermapstructure branch from 6e03ff2 to 34fdb44 Compare May 8, 2024 04:36
@evankanderson
Copy link
Member Author

This is ready for another review; it turns out the go-viper fork is starting with a v2 with an API that's compatible with v1. /shrug

@evankanderson evankanderson merged commit f716baa into mindersec:main May 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from mitchellh/mapstructure to go-viper/mapstructure
5 participants