Bump sigstore-go to v0.3.0 and add local registry for tests #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@stacklok.com>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@stacklok.com>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@stacklok.com>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@stacklok.com>
This commit adds a step to the tests workflow to spin up a new registry before running all th tests. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@stacklok.com>
puerco
changed the title
puerco
changed the title
jhrozek
approved these changes
Apr 24, 2024
|
@dmjb yes (or dependabot will once this merges) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit bumps the sigstore library to v0.3.0 which had a small breaking change.
For now, I added an internal constant for the sigstore media types replacing the constants that were removed from sigstore-go but added a new method to build the constants in sigstore/sigstore-go#154 . Once that change gets released I'll remove the internal consts.
This PR also adds a local registry to the test workflow to unit-test all OCI related functions (this PR includes one such test).
Supersedes #3062
Change Type
Mark the type of change your PR introduces:
Testing
This PR modifies the test workflow to spin up a registry and adds a test for the sigstore bundle function. The registry is will be available during the test workflow on localhost:5000
The PR also includes the tarred layouts of a signed image used as fixtures for testing the sigstore functions.
Review Checklist: