Add ProviderManager, make provider deletion generic #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #2845 Change the `ProviderFactory` to `ProviderManager`. Add new method for deleting provider instances. This hides provider-specific cleanup behind an appropriate interface, and removes some duplication of logic (with slightly different implementations) in different parts of the codebase.
dmjb
commented
Apr 24, 2024
| @@ -38,7 +38,7 @@ func CleanUpUnmanagedProjects( | |||
| proj uuid.UUID, | |||
| querier db.Querier, | |||
| authzClient authz.Client, | |||
| providerService service.GitHubProviderService, | |||
| providerManager manager.ProviderManager, | |||
There was a problem hiding this comment.
In future, I might investigate creating a ProjectService or similar - right now we end up having to pass around a bunch of dependencies through the controlplane for the project creation logic.
|
This is nice! I haven't tested manually, but the code is looking good. Is there anything in particular you're looking for to take this out of draft? |
|
@eleftherias I need to add some test coverage, and also do some manual verification of the changes. |
dmjb
commented
Apr 24, 2024
| @@ -22,6 +22,7 @@ import ( | |||
| "github.com/google/uuid" | |||
There was a problem hiding this comment.
I decided to reuse these test cases to test the deletion codepath in GitHubProviderClassManager
eleftherias
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2845
Change the
ProviderFactorytoProviderManager. Add new method for deleting provider instances. This hides provider-specific cleanup behind an appropriate interface, and removes some duplication of logic (with slightly different implementations) in different parts of the codebase.Most of the code changes relate to wiring this new logic into the rest of the codebase and replacing what was there.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: