Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the webhook secret from a file #3175

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Apr 25, 2024

Summary

Complements reading the previous webhook secret from a file by allowing
to read the current one.

Fixes: #3160

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

make test, use the option

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Complements reading the previous webhook secret from a file by allowing
to read the current one.

Fixes: mindersec#3160
@jhrozek jhrozek requested a review from a team as a code owner April 25, 2024 09:58
@coveralls
Copy link

Coverage Status

coverage: 50.138% (+0.02%) from 50.119%
when pulling a8710e1 on jhrozek:wh_from_file
into cea2520 on stacklok:main.

@jhrozek jhrozek merged commit e6ec651 into mindersec:main Apr 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add webhookSecretFile in addition to webhookSecret
3 participants