Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive error message when validating secrets with any of the fallback webhooks fails #3176

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Apr 25, 2024

Summary

Previously we would have returned a nil error but also a nil payload on
exhausting all previous secrets in a loop which would later error out when it
couldn't be parsed. That means that this bug has no security implications (we
would just get a 500 instead of a 400), but let's fix it nonetheless.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

manually + a unit test

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

…e fallback webhooks fails

Previously we would have returned a nil error but also a nil payload on
exhausting all previous secrets in a loop which would later error out when it
couldn't be parsed. That means that this bug has no security implications (we
would just get a 500 instead of a 400), but let's fix it nonetheless.
@jhrozek jhrozek requested a review from a team as a code owner April 25, 2024 11:06
@coveralls
Copy link

Coverage Status

coverage: 50.169% (+0.03%) from 50.144%
when pulling 6a8a876 on fallback_webhook_secret_fix
into e6ec651 on main.

@jhrozek jhrozek merged commit b135a03 into main Apr 25, 2024
21 checks passed
@jhrozek jhrozek deleted the fallback_webhook_secret_fix branch April 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants