More descriptive error message when validating secrets with any of the fallback webhooks fails #3176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we would have returned a nil error but also a nil payload on
exhausting all previous secrets in a loop which would later error out when it
couldn't be parsed. That means that this bug has no security implications (we
would just get a 500 instead of a 400), but let's fix it nonetheless.
Change Type
Mark the type of change your PR introduces:
Testing
manually + a unit test
Review Checklist: