Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm configuration for feature flags #3188

Conversation

evankanderson
Copy link
Member

Summary

Adds the ability to control configured Minder flags by creating a ConfigMap named minder-flags containing a key flags-config.yaml using a GoFeatureFlag config file.

See https://gofeatureflag.org/editor for a UI editor for the same.

Fixes #3187

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

I used my brain, sorry!

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner April 26, 2024 16:35
@evankanderson evankanderson linked an issue Apr 26, 2024 that may be closed by this pull request
@coveralls
Copy link

Coverage Status

coverage: 50.517% (-0.02%) from 50.534%
when pulling 7db2b22 on evankanderson:3187-allow-configuring-flags-in-helm-chart
into d8f7d57 on stacklok:main.

@evankanderson evankanderson merged commit a4eabe5 into mindersec:main Apr 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring flags in Helm chart
3 participants