Use ProviderManager in webhook handler #3202
Conversation
Relates to #2845
| @@ -864,9 +846,8 @@ func getPullRequestInfoFromPayload( | |||
| }, nil | |||
| } | |||
|
|
|||
| func reconcilePrWithDb( | |||
| func (s *Server) reconcilePrWithDb( | |||
There was a problem hiding this comment.
Changed some functions to methods so we do not need to pass around the db.Store pointer.
There was a problem hiding this comment.
Long-term, we want these to be in the provider implementation and not the server, correct?
| @@ -246,27 +243,6 @@ func (s *UnitTestSuite) TestHandleWebHookRepository() { | |||
| projectID := uuid.New() | |||
| providerID := uuid.New() | |||
|
|
|||
| // create a test oauth2 token | |||
There was a problem hiding this comment.
No longer needed because the token querying is not triggered unless the provider is actually instantiated. The test case for the handler does not need the provider to be instantiated.
dmjb
changed the title
| action string, | ||
| ) error { | ||
| // NOTE(jaosorior): this webhook is very specific to github |
There was a problem hiding this comment.
This comment is still true, we just think it's obvious, correct?
There was a problem hiding this comment.
Correct - but this particular codepath is so Github-specific that it's not really worth noting any more.
| @@ -864,9 +846,8 @@ func getPullRequestInfoFromPayload( | |||
| }, nil | |||
| } | |||
|
|
|||
| func reconcilePrWithDb( | |||
| func (s *Server) reconcilePrWithDb( | |||
There was a problem hiding this comment.
Long-term, we want these to be in the provider implementation and not the server, correct?
Relates to #2845
Switch to the use of the new ProviderManager interface in webhook handler to instantiate the Github provider.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: