Implement GitHubClientFactory #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #2845 For a future PR, I want to be able to easily instantiate the GitHub client without going through the provider creation process. This splits the code for creating the github client out into its own factory. As a bonus - this removes some code which is duplicated between the oauth and app provider instantiation flows.
dmjb
force-pushed
the
github-client-factory
branch
from
9a04caa
to
5b037c9
Compare
evankanderson
approved these changes
Apr 30, 2024
|
|
||
| // If $MINDER_LOG_GITHUB_REQUESTS is set, wrap the transport in a logger | ||
| // to record all calls and responses to from GitHub: | ||
| if os.Getenv("MINDER_LOG_GITHUB_REQUESTS") != "" { |
There was a problem hiding this comment.
We should move this to some actual configuration at some point, or remove this hook.
(Doesn't need to be part of this PR)
|
|
||
| // If $MINDER_LOG_GITHUB_REQUESTS is set, wrap the transport in a logger | ||
| // to record all calls and responses to from GitHub: | ||
| if os.Getenv("MINDER_LOG_GITHUB_REQUESTS") != "" { |
There was a problem hiding this comment.
Not for this PR, but it would be nice to keep a histogram of the values of x-ratelimit-remaining across our GitHub clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2845
For a future PR, I want to be able to easily instantiate the GitHub client without going through the provider creation process. Specifically - when creating providers, we end up partially creating a provider, storing it in the database, and then use instantiate it to verify that the user IDs are correct. I want to change this so that we instantiate the client without the provider to make the call we need.
This splits the code for creating the github client out into its own factory. As a bonus - this removes some code which is duplicated between the oauth and app provider instantiation flows.
Validated locally against both app and oauth flows.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: