Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug handling images with slashes in ref #3211

Merged
merged 2 commits into from
May 1, 2024

Conversation

puerco
Copy link
Contributor

@puerco puerco commented May 1, 2024

Summary

This commit fixes a bug when trying to list images with names in their reference. The github API expects the path segments after the org to be url escaped, for example:

 `ghcr.io/org/name/with/slahes`

needs to be

 `ghcr.io/org/name%2Fwith%2Fslahes`

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

TBD

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This commit fixes a bug when trying to list images with
    names in their reference. The github API expects everything
    after the org urls escaped, for exmaple:

     ghcr.io/org/name/with/slahes

    needs to be

     ghcr.io/org/name%2Fwith%2Fslahes

Signed-off-by: Adolfo García Veytia (puerco) <puerco@stacklok.com>
@puerco puerco added the bug Something isn't working label May 1, 2024
@puerco puerco requested a review from a team as a code owner May 1, 2024 04:31
@puerco puerco changed the title Fix bug handling images with slashes Fix bug handling images with slashes in ref May 1, 2024
@coveralls
Copy link

coveralls commented May 1, 2024

Coverage Status

coverage: 50.517% (+0.003%) from 50.514%
when pulling c06ebd5 on puerco:urlencode-bug
into 7c50e65 on stacklok:main.

@puerco puerco merged commit 1337072 into mindersec:main May 1, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants