Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return verified attestation in verification results #3212

Merged
merged 2 commits into from
May 1, 2024
Merged

Return verified attestation in verification results #3212

merged 2 commits into from
May 1, 2024

Conversation

puerco
Copy link
Contributor

@puerco puerco commented May 1, 2024

Summary

This PR modifies the artifact ingester to return the attestation after verifying ingested sigstore bundles.

Fixes ##3210

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@puerco
Return verified attestation in verification results
b8056d3 
This commit modifies the artifact verification results to
also include the verified attestation predicate to the evaluator.

Signed-off-by: Adolfo García Veytia (Puerco) <puerco@stacklok.com>
@puerco puerco added the bug Something isn't working label May 1, 2024
@puerco puerco requested a review from a team as a code owner May 1, 2024 04:45
@coveralls
Copy link

coveralls commented May 1, 2024 •
edited
Loading

Coverage Status

coverage: 50.503% (-0.01%) from 50.514%
when pulling 9bbbba3 on puerco:return-attestation
into 7c50e65 on stacklok:main.

@puerco puerco merged commit 087ba6b into mindersec:main May 1, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmjb dmjb dmjb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puerco @coveralls @dmjb