Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the identity extraction function to preserve the full path of the attestation identity recorded in the attestation identity.
Trimming the path opens up a vulnerability as an attestation may be validated by a signature triggered from a workflow with the same filename as the expected one.
The identity extraction function is still timing the branch and tag from the identity which we should probably also not do but we handle it in the rule definition so probably we are ok. Further discussion is needed.
Change Type
Mark the type of change your PR introduces:
Testing
Added a unit test to test the treatment of the signer identity
Review Checklist: