Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of ProviderBuilder by repo handler #3224

Merged
merged 1 commit into from
May 2, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented May 1, 2024

Relates to #2845

  1. Move the bulk provider instantiation for remote repo listing behind the provider manager interface.
  2. Change the repo creation method in the repo service to instantiate its own provider. The handler still queries the table of providers to search for an appropriate provider. I have decided to not put this behind the ProviderManager at this time since I feel like the right place to do this sort of logic may change in subsequent PRs.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Relates to #2845

1. Move the bulk provider instantiation for remote repo listing behind
   the provider manager interface.
2. Change the repo creation method in the repo service to instantiate
   its own provider. The handler still queries the table of providers to
   search for an appropriate provider. I have decided to not put this
   behind the ProviderManager at this time since I feel like the right
   place to do this sort of logic may change in subsequent PRs.
@dmjb dmjb requested a review from a team as a code owner May 1, 2024 17:03
@coveralls
Copy link

Coverage Status

coverage: 50.359% (-0.3%) from 50.625%
when pulling 954e589 on cleanup-repo-endpoints-providers
into b9daa61 on main.

@dmjb dmjb merged commit 3e08779 into main May 2, 2024
25 of 27 checks passed
@dmjb dmjb deleted the cleanup-repo-endpoints-providers branch May 2, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants