Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty provider in repo reconcile command #3231

Merged

Conversation

eleftherias
Copy link
Contributor

Summary

We don't need to validate the provider, since we validate the project ID.

Fixes #3223

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner May 2, 2024 15:34
@coveralls
Copy link

Coverage Status

coverage: 50.497% (+0.003%) from 50.494%
when pulling 87c9e12 on eleftherias:3223-repo-reconcile-no-provider
into ee66f6c on stacklok:main.

@eleftherias eleftherias merged commit 2310064 into mindersec:main May 3, 2024
21 checks passed
@eleftherias eleftherias deleted the 3223-repo-reconcile-no-provider branch May 3, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual repo reconciliation returns not found if provider is not set
4 participants