Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ProviderManager in reconciler #3232

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented May 2, 2024

Relates to #2845

Part of the ongoing decoupling of Provider-specific details from various parts of Minder.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Relates to #2845

Part of the ongoing decoupling of Provider-specific details from various
parts of Minder.
@dmjb dmjb requested a review from a team as a code owner May 2, 2024 20:41
@coveralls
Copy link

Coverage Status

coverage: 50.097% (+0.04%) from 50.056%
when pulling c3b009d on reconcilers-provider-manager
into 7fc9740 on main.

@dmjb dmjb merged commit 99212c7 into main May 3, 2024
24 of 25 checks passed
@dmjb dmjb deleted the reconcilers-provider-manager branch May 3, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants