Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added utilities to implement multi-select choices #3237

Merged
merged 2 commits into from
May 8, 2024
Merged

Added utilities to implement multi-select choices #3237

merged 2 commits into from
May 8, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented May 3, 2024

Summary

This also removes survey in favor of bubbletea.

Fixes #1134

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

dmjb
dmjb previously approved these changes May 7, 2024
@JAORMX
Copy link
Contributor

JAORMX commented May 7, 2024

oh! This didn't quite work for me. I built it, and tried to run it on my user. It lists all repos but I don't see a way to select them.

Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's verify it works.

@stacklokbot
Copy link
Contributor

Minder analyzed this PR with Trusty and found no dependencies scored lower than your profile threshold.

@blkt
Copy link
Contributor Author

blkt commented May 8, 2024

@JAORMX it should work as expected now, sorry for messing this up earlier.

Base automatically changed from issue-2627-cli to main May 8, 2024 08:27
@blkt blkt dismissed dmjb’s stale review May 8, 2024 08:27

The base branch was changed.

blkt added 2 commits May 8, 2024 10:28
@stacklokbot
Copy link
Contributor

Minder analyzed this PR with Trusty and found no dependencies scored lower than your profile threshold.

@blkt blkt merged commit 5aab39e into main May 8, 2024
19 of 20 checks passed
@blkt blkt deleted the issue-1134 branch May 8, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: move away from github.com/AlecAivazis/survey (archived)
4 participants