Remove ProviderBuilder #3282
Merged
Remove ProviderBuilder #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2845 Remove final usages of provider builder in CLI and delete code.
stacklokbot
reviewed
May 8, 2024
dmjb
commented
May 8, 2024
| return manager.NewProviderManager(providerStore, githubProviderManager) | ||
| } | ||
|
|
||
| func wireUpDB(ctx context.Context, cfg *serverconfig.Config) (db.Store, error) { |
There was a problem hiding this comment.
I refactored some of this code into separate functions out to reduce cyclomatic complexity of the runCmdWebhookUpdate (the new code I added exceeded the cyclomatic complexity limit)
dmjb
commented
May 8, 2024
| continue | ||
| } | ||
|
|
||
| whSecret, err := cfg.WebhookConfig.GetWebhookSecret() |
There was a problem hiding this comment.
As far as I can tell, this is constant across all iterations of the loop, so I moved it outside of the loop
dmjb
commented
May 8, 2024
| continue | ||
| } | ||
|
|
||
| if whSecret == "" { |
There was a problem hiding this comment.
If this is empty, no webhooks are updated, so I converted to an error condition (see line 263)
stacklokbot
reviewed
May 8, 2024
stacklokbot
reviewed
May 8, 2024
JAORMX
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2845
Remove final usages of provider builder in CLI and delete code.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: