Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stored procedure responsible for Profile status transitions now covers all cases #3295

Merged
merged 2 commits into from
May 10, 2024
Merged

Stored procedure responsible for Profile status transitions now covers all cases #3295

merged 2 commits into from
May 10, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented May 9, 2024 •
edited
Loading

Summary

Co-authored-by: Jakub Hrozek jakub@stacklok.com

Fixes #3087

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this May 9, 2024
stacklokbot
stacklokbot reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

@blkt blkt marked this pull request as ready for review May 9, 2024 20:55
@blkt blkt requested a review from a team as a code owner May 9, 2024 20:55
stacklokbot
stacklokbot reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

stacklokbot
stacklokbot reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Mixed Scripts Detected.

stacklokbot
stacklokbot reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

stacklokbot
stacklokbot reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Mixed Scripts Detected.

@coveralls
Copy link

coveralls commented May 9, 2024 •
edited
Loading

Coverage Status

coverage: 50.084% (-0.01%) from 50.095%
when pulling 58da1e1 on issue-3087
into f6b5176 on main.

JAORMX
JAORMX reviewed May 10, 2024
View reviewed changes
docker-compose.yaml Outdated
- "-c"
- "auto_explain.log_analyze=true"
- "-c"
- "auto_explain.log_triggers=true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could probably go in a separate PR.

JAORMX
JAORMX previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the PR LGTM

@blkt blkt mentioned this pull request May 10, 2024
Open
stacklokbot
stacklokbot reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

stacklokbot
stacklokbot reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Mixed Scripts Detected.

blkt added 2 commits May 10, 2024 09:25
@blkt
Stored procedure responsible for Profile status transitions now cover…
94e0eb9 
… all cases.

Fixes #3087

Co-authored-by: Jakub Hrozek jakub@stacklok.com
@blkt
comments
8f594ea
stacklokbot
stacklokbot reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

stacklokbot
stacklokbot reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Mixed Scripts Detected.

@blkt blkt merged commit 18c5a14 into main May 10, 2024
19 of 21 checks passed
@blkt blkt deleted the issue-3087 branch May 10, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacklokbot stacklokbot stacklokbot left review comments

@JAORMX JAORMX JAORMX approved these changes

Assignees

@blkt blkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The update_profile_status stored procedure keeps the error state if an error was rewritten to skipped
4 participants
@blkt @coveralls @JAORMX @stacklokbot