Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve test flake in flags_test #3305

Merged
merged 1 commit into from
May 10, 2024

Conversation

evankanderson
Copy link
Member

Summary

Don flagged this issue the other day. The simplest fix is to not run the sub-tests in parallel; I've also filed a comment on the upstream that it would be nice to be able to avoid the singleton, in the way that the net/http library has something like a "default ServeMux", but you can also create your own.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Fix in tests, the tests are the test.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner May 10, 2024 18:01
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

@coveralls
Copy link

Coverage Status

coverage: 49.294%. remained the same
when pulling 80dae64 on evankanderson:fix-flake
into 4c3fecd on stacklok:main.

@evankanderson evankanderson merged commit 052a79d into mindersec:main May 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants