Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi select list is now ordered. #3306

Merged
merged 1 commit into from
May 13, 2024
Merged

Multi select list is now ordered. #3306

merged 1 commit into from
May 13, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented May 11, 2024

This behaviour is not configurable.

Summary

List of available repositories during the interactive execution of minder repo register is now sorted.

This change was suggested by @rdimitrov

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Ran the Minder CLI locally against Production and verified that the list of repositories presented to the user during interactive registration are sorted.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This behaviour is not configurable.
@blkt blkt self-assigned this May 11, 2024
@blkt blkt requested a review from a team as a code owner May 11, 2024 09:21
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

@coveralls
Copy link

Coverage Status

coverage: 49.286% (-0.02%) from 49.305%
when pulling 177bc99 on repo-register-sort-selection
into 052a79d on main.

@blkt blkt merged commit b575d92 into main May 13, 2024
23 of 24 checks passed
@blkt blkt deleted the repo-register-sort-selection branch May 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants