Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hides CLI profile list label flag #3307

Merged
merged 2 commits into from
May 11, 2024

Conversation

ChrisJBurns
Copy link
Contributor

@ChrisJBurns ChrisJBurns commented May 11, 2024

Summary

At the moment, there are some labels that minder uses internally, but we don't expose label managements to the end user. Therefore the --label flag in profile list is confusing. We should make the flag hidden. We should use cobra's hidden attribute to hide the flag.

Fixes #3300

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Run make test, there are failures but not entirely sure they are related to the change made in the PR, and may be due to a local setup issue. I could not see any test change needed to be made, it is my first PR so I welcome any correction to my understanding.

When building the CLI, the label flag does not appear anymore in the help information
image

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns ChrisJBurns requested a review from a team as a code owner May 11, 2024 15:53
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

@CLAassistant
Copy link

CLAassistant commented May 11, 2024

CLA assistant check
All committers have signed the CLA.

cmd/cli/app/profile/list.go Outdated Show resolved Hide resolved
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Mixed Scripts Detected.

@JAORMX JAORMX merged commit 4c9a0a8 into mindersec:main May 11, 2024
20 checks passed
@ChrisJBurns ChrisJBurns deleted the hides-profile-list-label-flag branch May 11, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the --label flag hiden
4 participants