-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hides CLI profile list label flag #3307
Merged
JAORMX
merged 2 commits into
mindersec:main
from
ChrisJBurns:hides-profile-list-label-flag
May 11, 2024
Merged
hides CLI profile list label flag #3307
JAORMX
merged 2 commits into
mindersec:main
from
ChrisJBurns:hides-profile-list-label-flag
May 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
stacklokbot
reviewed
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ No Invisible Unicode Characters Detected.
JAORMX
reviewed
May 11, 2024
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
stacklokbot
reviewed
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ No Invisible Unicode Characters Detected.
stacklokbot
reviewed
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ No Mixed Scripts Detected.
JAORMX
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At the moment, there are some labels that minder uses internally, but we don't expose label managements to the end user. Therefore the
--label
flag in profile list is confusing. We should make the flag hidden. We should use cobra's hidden attribute to hide the flag.Fixes #3300
Change Type
Mark the type of change your PR introduces:
Testing
Run
make test
, there are failures but not entirely sure they are related to the change made in the PR, and may be due to a local setup issue. I could not see any test change needed to be made, it is my first PR so I welcome any correction to my understanding.When building the CLI, the
label
flag does not appear anymore in the help informationReview Checklist: