Support dockerhub in mindev ruletype test sub-command
#3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
stacklokbot
reviewed
May 13, 2024
jhrozek
approved these changes
May 13, 2024
| @@ -59,6 +61,8 @@ func CmdTest() *cobra.Command { | |||
| testCmd.Flags().StringP("rule-type", "r", "", "file to read rule type definition from") | |||
| testCmd.Flags().StringP("entity", "e", "", "YAML file containing the entity to test the rule against") | |||
| testCmd.Flags().StringP("profile", "p", "", "YAML file containing a profile to test the rule against") | |||
| testCmd.Flags().StringP("provider", "P", "github", "The provider class to test the rule against") | |||
| testCmd.Flags().StringP("provider-config", "c", "", "YAML file containing the provider configuration (optional)") | |||
There was a problem hiding this comment.
In a follow-up it might be nice to also support reading from stdin
There was a problem hiding this comment.
True! I'll keep it in mind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note that dockerhub still doesn't fully work, but this sets up the pieces so we can start testing it.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: