Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verifier: Move registry to authenticator #3320

Merged
merged 1 commit into from
May 13, 2024
Merged

verifier: Move registry to authenticator #3320

merged 1 commit into from
May 13, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented May 13, 2024

Summary

Since auth is related to the registry itself, this moves the registry
reference to the container authenticator struct instead.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner May 13, 2024 13:18
stacklokbot
stacklokbot reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

@JAORMX
verifier: Move registry to authenticator
032a560 
Since auth is related to the registry itself, this moves the registry
reference to the container authenticator struct instead.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
stacklokbot
stacklokbot reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

stacklokbot
stacklokbot reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Mixed Scripts Detected.

@coveralls
Copy link

Coverage Status

coverage: 49.28% (-0.04%) from 49.318%
when pulling 032a560 on reg-cont-auth
into 16c3e60 on main.

@JAORMX JAORMX merged commit 4048e68 into main May 13, 2024
20 checks passed
@JAORMX JAORMX deleted the reg-cont-auth branch May 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacklokbot stacklokbot stacklokbot left review comments

@jhrozek jhrozek jhrozek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JAORMX @coveralls @jhrozek @stacklokbot