Initial KeyStore implementation #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #3304 Implement an interface which hides the specifics of loading an encryption key. This allows us to use a secret store or a key store directly in future. Right now, the implementation uses a single key loaded from the config. In my next PR, I will generalize it to support multiple keys. This will require a new config structure.
stacklokbot
reviewed
May 14, 2024
dmjb
commented
May 14, 2024
| type aesCFBSAlgorithm struct { | ||
| encryptionKey []byte | ||
| } | ||
| // AES256CFBAlgorithm implements the AES-256-CFB algorithm |
There was a problem hiding this comment.
The algorithm.go file has grown quite large, I split it in two as part of this PR.
stacklokbot
reviewed
May 14, 2024
stacklokbot
reviewed
May 14, 2024
stacklokbot
reviewed
May 14, 2024
stacklokbot
reviewed
May 14, 2024
jhrozek
reviewed
May 14, 2024
stacklokbot
reviewed
May 14, 2024
stacklokbot
reviewed
May 14, 2024
jhrozek
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3304
Implement an interface which hides the specifics of loading an encryption key. This allows us to use a secret store or a key store directly in future.
Right now, the implementation uses a single key loaded from the config. In my next PR, I will generalize it to support multiple keys. This will require a new config structure.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: