Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new column for new encyrption format #3331

Merged
merged 1 commit into from
May 14, 2024
Merged

Add new column for new encyrption format #3331

merged 1 commit into from
May 14, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented May 14, 2024

Relates to #3315

Add new JSONB columns to session store and access tokens table which will be used to store encrypted data along with its metadata (algorithm type, key, salt).

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Relates to #3315

Add new JSONB columns to session store and access tokens table which
will be used to store encrypted data along with its metadata (algorithm
type, key, salt).
@dmjb dmjb requested a review from a team as a code owner May 14, 2024 16:21
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

@@ -4,9 +4,6 @@ INSERT INTO session_store (provider, project_id, remote_user, session_state, own
-- name: GetProjectIDBySessionState :one
SELECT provider, project_id, remote_user, owner_filter, redirect_url FROM session_store WHERE session_state = $1;

-- name: DeleteSessionState :exec
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used anywhere.

@coveralls
Copy link

Coverage Status

coverage: 49.151% (+0.02%) from 49.135%
when pulling a9d2ac0 on encrypted-data-column
into daccbc1 on main.

@dmjb dmjb merged commit fcf857b into main May 14, 2024
25 of 26 checks passed
@dmjb dmjb deleted the encrypted-data-column branch May 14, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants