Trusty: Refactor alternative classification, add tests #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adolfo García Veytia (puerco) <puerco@stacklok.com>
This commit breaks the classification logic into more specialized functions to make it testable, it also adds tests for some of the new functions. Signed-off-by: Adolfo García Veytia (puerco) <puerco@stacklok.com>
stacklokbot
reviewed
May 15, 2024
dmjb
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit refactors the alternative dependency classification logic and makes it testable. I've added more tests to check the classification behavior and to verify the score matrix we pass to the PR template.
Change Type
Testing
Review Checklist: