Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency-review pipeline #3341

Merged
merged 1 commit into from
May 16, 2024
Merged

Remove dependency-review pipeline #3341

merged 1 commit into from
May 16, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented May 16, 2024

Summary

This is already done by minder's integration with trusty, no need to do
it twice.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This is already done by minder's integration with trusty, no need to do
it twice.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested a review from a team as a code owner May 16, 2024 09:45
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

@lukehinds lukehinds merged commit 42d4c35 into main May 16, 2024
20 of 21 checks passed
@lukehinds lukehinds deleted the rm-dep branch May 16, 2024 09:52
@coveralls
Copy link

Coverage Status

coverage: 49.418% (+0.01%) from 49.407%
when pulling 0b0e57a on rm-dep
into 4a868e3 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants