Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go generate statement from keystore #3344

Merged
merged 1 commit into from
May 16, 2024
Merged

Remove go generate statement from keystore #3344

merged 1 commit into from
May 16, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented May 16, 2024

Summary

This is not needed and needlessly generates mocks we don't use.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This is not needed

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested a review from a team as a code owner May 16, 2024 10:37
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

@JAORMX JAORMX mentioned this pull request May 16, 2024
10 tasks
@coveralls
Copy link

Coverage Status

coverage: 49.407% (-0.01%) from 49.418%
when pulling 255650e on rm-gen-keystore
into 42d4c35 on main.

@JAORMX JAORMX merged commit 1eb80d3 into main May 16, 2024
21 checks passed
@JAORMX JAORMX deleted the rm-gen-keystore branch May 16, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants