Github provider: Add support for checks API #3352
Conversation
internal/providers/github/common.go
Outdated
| @@ -64,6 +64,9 @@ var ( | |||
| ErrBranchNotFound = errors.New("branch not found") | |||
| // ErrNoPackageListingClient denotes if there is no package listing client available | |||
| ErrNoPackageListingClient = errors.New("no package listing client available") | |||
| // ErroNoCheckPerissions is a fixed error returned when the credentialed | |||
| // identity has not been authorized to use the checks API | |||
| ErroNoCheckPerissions = errors.New("missing permissions: check") | |||
There was a problem hiding this comment.
Do we have the permission by default with the GH App? I think we don't with the OAuth token we request..
There was a problem hiding this comment.
I'm adding these APIs so that we can get rid of the comment spam.
Currently, we don't have permissions for the checks, this is why I created a custom error that traps it, so that we can handle runs without them. I think we will have to support running without it, at least for a while.
There was a problem hiding this comment.
I believe that the checks API is only available to GitHub Apps:
If you aren't building a GitHub App, you might be interested in using the REST API to interact with commit statuses.
There was a problem hiding this comment.
That's not to say that we should limit ourselves to the lowest common denominator.
There was a problem hiding this comment.
Yes, this is why the OSV evaluator uses commit statuses (the OSV evaluator predates the GH app)
|
Thanks for catching those @rdimitrov I promise not to code without my glasses again 😄 |
This commit adds support for the checks API in the github provider. Signed-off-by: Adolfo García Veytia (puerco) <puerco@stacklok.com>
Summary
This commit adds support for the checks API in the github provider.
Change Type
Mark the type of change your PR introduces:
Testing
Review Checklist: