Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to AES-256-GCM encryption for secrets #3356

Merged
merged 2 commits into from
May 22, 2024
Merged

Switch to AES-256-GCM encryption for secrets #3356

merged 2 commits into from
May 22, 2024

Commits on May 21, 2024

  1. Use AES-256-GCM encryption by default 

    Fixes #3317

Use GCM encryption as the default encryption algorithm for Minder. At this
point, we now have a hard requirement to use the new EncryptedData structure in
the database - the old columns (for the access token, and for the redirect URL)
do not track the algorithm used. As part of the migration away from the old
columns, I have made the following changes in this PR:

1. Make the old columns nullable
2. Stop writing to the old columns
3. Change all unit tests which relied on the old columns
    @dmjb
    dmjb committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1d923c4 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge branch 'main' into random-salt

    @dmjb
    dmjb authored May 22, 2024
    Configuration menu
    Copy the full SHA
    11285ae View commit details
    Browse the repository at this point in the history