Handle package not found in package registries #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacklokbot
reviewed
May 18, 2024
|
This is a draft because a) there are no tests and b) I think there is room for improvement (see inline comments) |
jhrozek
commented
May 18, 2024
jhrozek
commented
May 18, 2024
jhrozek
commented
May 18, 2024
stacklokbot
reviewed
May 19, 2024
stacklokbot
reviewed
May 19, 2024
If we don't find a package in the configured package registry, we would have errored out. Let's instead reply inline that there is a vulnerability but that we can't find information about the package.
stacklokbot
reviewed
May 20, 2024
stacklokbot
reviewed
May 20, 2024
JAORMX
previously approved these changes
May 20, 2024
| @@ -386,6 +393,9 @@ func TestPyPiPkgDb(t *testing.T) { | |||
| } | |||
| reply, err := repo.SendRecvRequest(context.Background(), dep, tt.patchedVersion, latest) | |||
| if tt.expectError { | |||
| if tt.errorToExpect != nil { | |||
| assert.Equal(t, tt.errorToExpect, err, "Expected error") | |||
There was a problem hiding this comment.
why not use assert.ErrorIs?
There was a problem hiding this comment.
because I'm dumb :-) let me fix it
rdimitrov
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If we don't find a package in the configured package registry, we would
have errored out. Let's instead reply inline that there is a
vulnerability but that we can't find information about the package.
Fixes: #3368
Change Type
Testing
Manual testing, see e.g. jakubtestorg/demo-repo-js#4
Review Checklist: