Enhanced GitHub webhook handler tests. #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blkt
force-pushed
the
issue-3358
branch
3 times, most recently
from
48ae4ea
to
a658174
Compare
blkt
commented
May 20, 2024
Comment on lines
+715
to
+721
| // Previous lookup was done at this path | ||
| // ".package.package_version.container_metadata.tag.name", | ||
| // which is unfortunately not have available under go-github, | ||
| // as field "container_metadata" is missing form its structs. | ||
| // I suggest using the following, although it's still to be | ||
| // verified whether that's the right one. | ||
| tag, err := util.JQReadFrom[string](ctx, ".package.package_version.tag_name", payload) |
There was a problem hiding this comment.
Please have a look at this, I'm not sure this is 100% correct.
Comment on lines
+107
to
+111
| &serverconfig.ProviderConfig{ | ||
| GitHubApp: &serverconfig.GitHubAppConfig{ | ||
| WebhookSecret: "test", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I'm not particularly happy about these lines of code, but they do not impact any other test as of now. Ideally, it should be easy to start a simple server just for testing, but I did not want to pollute this PR more than necessary.
Please, let me know your opinions on this.
There was a problem hiding this comment.
this might not be as necessary with this #3371
dmjb
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is only about adding test coverage to GitHub webhook handler.
Fixes #3358
Review Checklist: