Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new helm variables for new crypto config #3378

Merged
merged 1 commit into from
May 21, 2024
Merged

Add new helm variables for new crypto config #3378

merged 1 commit into from
May 21, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented May 20, 2024

Relates to #3315

These new variables will be used to add the new crypto config for the staging and production configs.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Relates to #3315

These new variables will be used to add the new crypto config for the
staging and production configs.
@dmjb dmjb requested a review from a team as a code owner May 20, 2024 16:04
@coveralls
Copy link

Coverage Status

coverage: 49.944% (-0.01%) from 49.955%
when pulling f376d97 on split-token-config
into 2d7e6b3 on main.

@dmjb dmjb changed the title Add new TF variables for new crypto config Add new helm variables for new crypto config May 21, 2024
@dmjb dmjb merged commit 949b313 into main May 21, 2024
24 of 25 checks passed
@dmjb dmjb deleted the split-token-config branch May 21, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants