Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CreateProvider rpc handler #3385

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented May 21, 2024

Summary

Adds a Server.CreateProvider() handler that implements the already
existing grpc method. Adds tests.

Fixes: #3376

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Adds a Server.CreateProvider() handler that implements the already
existing grpc method. Adds tests.

Fixes: mindersec#3376
@jhrozek jhrozek requested a review from a team as a code owner May 21, 2024 09:35
@coveralls
Copy link

Coverage Status

coverage: 51.878% (+0.5%) from 51.352%
when pulling cf61638 on jhrozek:create_provider_rpc
into 949b313 on stacklok:main.

Copy link
Contributor

@dmjb dmjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I love how little logic is in this handler :)

@jhrozek jhrozek merged commit 99f8dbe into mindersec:main May 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to create new providers with custom configuration in providerManager and through an RPC call
3 participants