Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip alerts if provider does not support it #3386

Merged
merged 1 commit into from
May 21, 2024
Merged

Skip alerts if provider does not support it #3386

merged 1 commit into from
May 21, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented May 21, 2024

Summary

The idea is to make artifact rules more re-usable. This detects if the
provider implements GitHub and if it doesn't it merely returns a no-op
alert engine. This is handy to be able to test artifact_signature rule
types with DockerHub or any othe provider that's not GitHub.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

The idea is to make artifact rules more re-usable. This detects if the
provider implements `GitHub` and if it doesn't it merely returns a no-op
alert engine. This is handy to be able to test `artifact_signature` rule
types with DockerHub or any othe provider that's not GitHub.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested a review from a team as a code owner May 21, 2024 11:14
@coveralls
Copy link

Coverage Status

coverage: 51.357% (+0.005%) from 51.352%
when pulling 98fab72 on skip-alerts
into 949b313 on main.

@JAORMX JAORMX merged commit 9442be0 into main May 21, 2024
21 checks passed
@JAORMX JAORMX deleted the skip-alerts branch May 21, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants