Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VerifyProviderTokenIdentity to the GitHubProviderService #3389

Merged
merged 2 commits into from
May 21, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented May 21, 2024

Summary

These two commits will allow to pass provider configuration during OAuth enrollment

Related #3263

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

this will be properly tested in a follow-up patch

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek jhrozek requested a review from a team as a code owner May 21, 2024 12:50
@coveralls
Copy link

Coverage Status

coverage: 51.882% (+0.02%) from 51.867%
when pulling 5e0c1bf on jhrozek:verify_in_service
into 99f8dbe on stacklok:main.

@jhrozek jhrozek merged commit a771115 into mindersec:main May 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants