Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race in TestProviderManager_CreateFromConfig #3402

Merged
merged 1 commit into from
May 22, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented May 22, 2024

Summary

To test:

go test ./internal/providers/manager -race -run TestProviderManager_CreateFromConfig

Fixes #3397

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

see above

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

To test:
```
go test ./internal/providers/manager -race -run TestProviderManager_CreateFromConfig
```
@jhrozek jhrozek requested a review from a team as a code owner May 22, 2024 07:27
@jhrozek jhrozek merged commit abf4c0d into mindersec:main May 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data race in CreateProvider tests
2 participants