Move provider OAuth config under server.Config #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's remove this code, it's unused and we're moving to keeping the data in a structure.
The next patch will add yet another place where this pattern is used, let's not add yet another repeated piece of code.
Add a config structure to keep the OAuth client configuration so that we can pass a structure to providers instead of reading the config attributes directly with viber.
dmjb
approved these changes
May 23, 2024
JAORMX
added a commit
that referenced
this pull request
May 27, 2024
#3410 removed manually-registered command line flags we were using to set these. Let's set them as env variables instead. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
10 tasks
jhrozek
pushed a commit
to jhrozek/minder
that referenced
this pull request
May 27, 2024
mindersec#3410 removed manually-registered command line flags we were using to set these. Let's set them as env variables instead. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
jhrozek
added a commit
that referenced
this pull request
May 27, 2024
…3429) * Fix reading fallback values for the GH providers * Pass in github provider settings from env variables #3410 removed manually-registered command line flags we were using to set these. Let's set them as env variables instead. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com> --------- Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com> Co-authored-by: Juan Antonio Osorio <ozz@stacklok.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the next PR (#3334) we need to move the OAuth config under providers
themselves, but in order to do that, we need to get rid of the oauth client
config code calling
viper.Getdirectly or else we'll break all our tests.This PR does that and gets rid of the Google OAuth configuration and other
now-unused code.
Because the next PR will move the OAuth client code around to providers, I
didn't get overboard with testing here.
Fixes #2798
Change Type
Testing
make test and provider enroll
Review Checklist: