Further enhancing webhook handler tests. #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically * interaction with the database is tested accurately * message lookup on Minder internal topics is not on a per-test basis * message payloads checks are on a per-test basis * added a couple more test cases
blkt
force-pushed
the
webhook-further-testing
branch
from
f43b327
to
8e00b04
Compare
dmjb
reviewed
May 24, 2024
| @@ -52,9 +53,12 @@ import ( | |||
| "github.com/stacklok/minder/internal/util/testqueue" | |||
| ) | |||
|
|
|||
| //go:embed package-published.json | |||
| //go:embed test-payloads/package-published.json | |||
There was a problem hiding this comment.
Great idea, definitely going to use this pattern in future.
dmjb
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR only adds tests and there are no changes to business logic.
Specifically
Change Type
Test improvement.
Review Checklist: