Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefiles #3420

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix Makefiles #3420

merged 1 commit into from
May 27, 2024

Conversation

prezha
Copy link
Contributor

@prezha prezha commented May 26, 2024

Summary

  • sole make should only call help
  • fix command concatenation and remove unnecessary end-of-line in
    main Makefile
  • add make clean to init-examples and aggregate it with main Makefile
  • enable init-examples to be run from main Makefile and its own
    Makefile

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

 - sole make should only call help

 - fix command concatenation and remove unnecessary end-of-line in
   main Makefile

 - add make clean to init-examples and aggregate it with main Makefile

 - enable init-examples to be run from main Makefile as well as from
   its own Makefile
@prezha prezha requested a review from a team as a code owner May 26, 2024 21:59
@prezha
Copy link
Contributor Author

prezha commented May 26, 2024

looks like only the TestCreateProfileStatusMultiRuleTransitions/0x90 test failed - probably not related to this change: could it be due to a race condition as these tests are run in parallel?


edit: this could be related: #3299

@coveralls
Copy link

Coverage Status

coverage: 51.964% (-0.02%) from 51.98%
when pulling b5647e3 on prezha:makefiles
into 586144c on stacklok:main.

@JAORMX JAORMX merged commit ecf8283 into mindersec:main May 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants