Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually return an error on branch protection get #3434

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented May 27, 2024

Summary

We were accidentally skipping error returning since we had missed a
return statement in that function.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We were accidentally skipping error returning since we had missed a
`return` statement in that function.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested a review from a team as a code owner May 27, 2024 11:15
@JAORMX JAORMX merged commit 64a22e8 into main May 27, 2024
19 checks passed
@JAORMX JAORMX deleted the error-branch-prot branch May 27, 2024 11:22
@coveralls
Copy link

Coverage Status

coverage: 52.011% (+0.002%) from 52.009%
when pulling e56a490 on error-branch-prot
into 7d2b11e on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants