Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch protection remediation now uses default branch if none provided. #3436

Merged
merged 1 commit into from
May 27, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented May 27, 2024

Summary

Branch protection remediation now checks if branch name is empty and gets the default branch if available.
If both are unavailable, remediation is skipped.

Co-authored-by: Juan Antonio Osorio ozz@stacklok.com
Fixes #3430

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manually tested.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this May 27, 2024
@blkt blkt requested a review from a team as a code owner May 27, 2024 12:20
@blkt blkt merged commit db00a0f into main May 27, 2024
21 checks passed
@blkt blkt deleted the branch-protection-remediation-default-branch branch May 27, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch protection remediation panics on empty branch name
2 participants