Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cron jobs to helm chart to purge and rotate secrets #3460

Merged
merged 1 commit into from
May 31, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented May 30, 2024

Summary

This adds jobs so we can purge sessions and rotate provider secrets in
an automated fashion.

Related-To: #3315

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner May 30, 2024 10:33
@coveralls
Copy link

coveralls commented May 30, 2024

Coverage Status

coverage: 52.376% (+0.01%) from 52.365%
when pulling 08fdbec on secret-rotation-jobs
into 300d857 on main.

Copy link
Contributor

@dmjb dmjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but let's avoid merging until we have rolled out a new encryption key to staging first.

This adds jobs so we can purge sessions and rotate provider secrets in
an automated fashion.

Related-To: #3315

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Co-authored-by: Don Browne <dmjb@users.noreply.github.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX merged commit 4bb3350 into main May 31, 2024
20 checks passed
@JAORMX JAORMX deleted the secret-rotation-jobs branch May 31, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants