Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile target to generate encryption key #3464

Merged
merged 1 commit into from
May 30, 2024
Merged

Add Makefile target to generate encryption key #3464

merged 1 commit into from
May 30, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented May 30, 2024

Summary

This is useful when doing key rotation and allows us to use the same
command when doing so.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This is useful when doing key rotation and allows us to use the same
command when doing so.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested a review from a team as a code owner May 30, 2024 12:01
@coveralls
Copy link

Coverage Status

coverage: 52.376% (+0.01%) from 52.365%
when pulling e690d5a on gen-ekey
into 300d857 on main.

@JAORMX JAORMX merged commit 16e3ca0 into main May 30, 2024
21 checks passed
@JAORMX JAORMX deleted the gen-ekey branch May 30, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants