Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the pinned action support to use the new frizbee version #3465

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented May 30, 2024

Summary

The following PR updates the existing code using Frizbee to the new version.

What's left:

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Tested by recreating the smoke test using a local Minder instance - https://github.com/radoslav-dev/demo-repo-python/pull/19/files

  • Created a profile with the given ruletype -> profile status was pending -> registered the test repo -> profile was failing -> enabled remediations -> profile status was failing but opened a PR with the suggested replacements -> accepted the PR -> profile status is OK
  • Another test after the release - https://github.com/radoslav-dev/frizbee-test/pull/1/files

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@coveralls
Copy link

coveralls commented Jun 3, 2024

Coverage Status

coverage: 52.47% (-0.001%) from 52.471%
when pulling 9afc882 on frizbee-switch
into b05c9d9 on main.

@jhrozek
Copy link
Contributor

jhrozek commented Jun 3, 2024

FWIW, I tested this PR with the frizbee rework PR and it works fine. I tested both "normal" actions and docker actions.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov marked this pull request as ready for review June 4, 2024 07:41
@rdimitrov rdimitrov requested a review from a team as a code owner June 4, 2024 07:41
@rdimitrov rdimitrov merged commit a896873 into main Jun 4, 2024
20 checks passed
@rdimitrov rdimitrov deleted the frizbee-switch branch June 4, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants