Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workflow that checks if make gen was run #3476

Merged
merged 3 commits into from
May 31, 2024
Merged

Add a workflow that checks if make gen was run #3476

merged 3 commits into from
May 31, 2024

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented May 31, 2024

Summary

The following PR adds a workflow which ensures make gen was run.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner May 31, 2024 09:06
@rdimitrov rdimitrov self-assigned this May 31, 2024
@coveralls
Copy link

coveralls commented May 31, 2024

Coverage Status

coverage: 52.347% (+0.02%) from 52.331%
when pulling 6e4c1bd on makegen
into 8b934c8 on main.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov force-pushed the makegen branch 2 times, most recently from 18ee236 to 5d9ab99 Compare May 31, 2024 09:34
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov merged commit 86c56e2 into main May 31, 2024
20 checks passed
@rdimitrov rdimitrov deleted the makegen branch May 31, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants