Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User minder-config for secret cleanup/rotation jobs #3477

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented May 31, 2024

Summary

We don't want to give these jobs database schema change privileges. So
let's just use the minder config there instead.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We don't want to give these jobs database schema change privileges. So
let's just use the minder config there instead.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested a review from a team as a code owner May 31, 2024 09:07
@dmjb dmjb merged commit bebb689 into main May 31, 2024
19 checks passed
@dmjb dmjb deleted the jobs-minder-config branch May 31, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants