Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error when unable to fetch credentials #3481

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented May 31, 2024

Summary

We're seeing issues in staging that are hard to debug because we don't log the error

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

make build

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek jhrozek requested a review from a team as a code owner May 31, 2024 09:40
@coveralls
Copy link

Coverage Status

coverage: 52.331%. remained the same
when pulling 5dd6daf on jhrozek:misc
into 86c56e2 on stacklok:main.

@dmjb dmjb merged commit fa764bc into mindersec:main May 31, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants