Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook handler always logs contextual information. #3483

Merged
merged 1 commit into from
May 31, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented May 31, 2024

Summary

This change makes uniform use of details stored in ctx when writing logs in the webhook handler. Additionally, it also moves watermill message UUID logging key from "event" to "message_uuid" to use the same one as watermill.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

  • make lint
  • local execution

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This change makes uniform use of details stored in ctx when writing
logs in the webhook handler. Additionally, it also moves watermill
message UUID logging key from "event" to "message_uuid" to use the
same one as watermill.
@blkt blkt self-assigned this May 31, 2024
@blkt blkt requested a review from a team as a code owner May 31, 2024 11:32
@coveralls
Copy link

Coverage Status

coverage: 52.404% (+0.03%) from 52.377%
when pulling 8fa5219 on webhook-logs-enhancements
into 2934f33 on main.

@blkt blkt merged commit 330ccec into main May 31, 2024
21 checks passed
@blkt blkt deleted the webhook-logs-enhancements branch May 31, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants