Dual write rule instances to new and old tables

database/migrations/000061_rule_instance_not_null_def.down.sql

@@ -0,0 +1,20 @@
+-- Copyright 2024 Stacklok, Inc
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--      http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+BEGIN;
+
+ALTER TABLE rule_instances ALTER COLUMN def DROP NOT NULL;
+ALTER TABLE rule_instances ALTER COLUMN params DROP NOT NULL;
+
+COMMIT;

database/migrations/000061_rule_instance_not_null_def.up.sql

@@ -0,0 +1,20 @@
+-- Copyright 2024 Stacklok, Inc
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--      http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+BEGIN;
+
+ALTER TABLE rule_instances ALTER COLUMN def SET NOT NULL;
+ALTER TABLE rule_instances ALTER COLUMN params SET NOT NULL;
+
+COMMIT;

internal/profiles/service.go

@@ -27,7 +27,6 @@ import (
 	"strings"
 
 	"github.com/google/uuid"
-	"github.com/sqlc-dev/pqtype"
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
 	"google.golang.org/protobuf/reflect/protoreflect"
@@ -773,22 +772,14 @@ func upsertRuleInstances(
 			return nil, fmt.Errorf("unable to serialize rule params: %w", err)
 		}
 
-		newInstance := db.UpsertRuleInstanceParams{
+		id, err := qtx.UpsertRuleInstance(ctx, db.UpsertRuleInstanceParams{
 			ProfileID:  profileID,
 			RuleTypeID: entityRuleTuple.RuleID,
 			Name:       rule.Name,
 			EntityType: entityType,
-			Def: pqtype.NullRawMessage{
-				RawMessage: def,
-				Valid:      def != nil,
-			},
-			Params: pqtype.NullRawMessage{
-				RawMessage: params,
-				Valid:      params != nil,
-			},
-		}
-
-		id, err := qtx.UpsertRuleInstance(ctx, newInstance)
+			Def:        def,
+			Params:     params,
+		})
 		if err != nil {
 			return nil, fmt.Errorf("unable to insert new rule instance: %w", err)
 		}